Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Subtask] Improve the EntityStore interface to add more methods #112

Closed
Tracked by #4
jerryshao opened this issue Jul 21, 2023 · 0 comments · Fixed by #115
Closed
Tracked by #4

[Subtask] Improve the EntityStore interface to add more methods #112

jerryshao opened this issue Jul 21, 2023 · 0 comments · Fixed by #115
Assignees
@jerryshao
Labels
subtask Subtasks of umbrella issue

Comments

@jerryshao
Copy link
Contributor

Describe the subtask

Current EntityStore only has two methods related to store and retrieve, which is not enough to satisfy all the needs for entity storage. So here improved to add more methods.

Parent issue

#4
@jerryshao jerryshao added the subtask Subtasks of umbrella issue label Jul 21, 2023
@jerryshao jerryshao self-assigned this Jul 21, 2023
This was referenced Jul 14, 2023
Closed
Closed
Merged
jerryshao added a commit that referenced this issue Jul 24, 2023
@jerryshao
[#112] refactor(core): improve the EntityStore interface to add mor…
89682eb 
…e methods (#115)

### What changes were proposed in this pull request?

This PR refactors the `EntityStore` to add more interfaces, so that
other implementations could leverage this to achieve the specific
logics.

### Why are the changes needed?

Current EntityStore only has two methods related to store and retrieve,
which is not enough to satisfy all the needs for entity storage. So here
improved to add more methods.

Fix: #112 

### Does this PR introduce _any_ user-facing change?

Yes, this change refactors the current `EntityStore` interface to add
more methods.

### How was this patch tested?

Extends the current UT.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jerryshao jerryshao

Labels
subtask Subtasks of umbrella issue
Projects
None yet
Milestone
No milestone
1 participant
@jerryshao