Skip to content

Commit

Permalink
[#2118] docs(trino configuration): change gravitino.url to gravitino.…
Browse files Browse the repository at this point in the history
…uri (#2136)

<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
   Examples:
     - "[#123] feat(operator): support xxx"
     - "[#233] fix: check null before access result in xxx"
     - "[MINOR] refactor: fix typo in variable name"
     - "[MINOR] docs: fix typo in README"
     - "[#255] test: fix flaky test NameOfTheTest"
   Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. If the PR is unfinished, please mark this PR as draft.
-->

### What changes were proposed in this pull request?

Change `gravitino.url` to `gravitino.uri`.

### Why are the changes needed?

The example in trino-connector/installation.md uses different keys for
gravitino link.


https://github.com/datastrato/gravitino/blob/edfcdbea89dbf16d8e48833573c8917f9bcd5972/docs/trino-connector/installation.md?plain=1#L75-L81

From source code, it should be `gravitino.uri`.


https://github.com/datastrato/gravitino/blob/edfcdbea89dbf16d8e48833573c8917f9bcd5972/trino-connector/src/main/java/com/datastrato/gravitino/trino/connector/GravitinoConfig.java#L22

We also need to fix the one in trino-connector/configuration.md.


https://github.com/datastrato/gravitino/blob/edfcdbea89dbf16d8e48833573c8917f9bcd5972/docs/trino-connector/configuration.md?plain=1#L13

Fix: #2118

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

Check there is no `gravitino.url` in the document.

Signed-off-by: PoAn Yang <[email protected]>
  • Loading branch information
FrankYang0529 authored and web-flow committed Feb 8, 2024
1 parent 159fda5 commit d213576
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion docs/trino-connector/configuration.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ This software is licensed under the Apache License version 2."
|--------------------|--------|-----------------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|----------|---------------|
| connector.name | string | (none) | The `connector.name` defines the name of Trino connector, this value is always 'gravitino'. | Yes | 0.2.0 |
| gravitino.metalake | string | (none) | The `gravitino.metalake` defines which metalake in Gravitino server the Trino connector uses. Trino connector should set it at start, the value of `gravitino.metalake` needs to be a valid name, Trino connector can detect and load the metalake with catalogs, schemas and tables once created and keep in sync. | Yes | 0.2.0 |
| gravitino.url | string | http://localhost:8090 | The `gravitino.url` defines the connection URL of the Gravitino server, the default value is `http://localhost:8090`. Trino connector can detect and connect to Gravitino server once it is ready, no need to start Gravitino server beforehand. | Yes | 0.2.0 |
| gravitino.uri | string | http://localhost:8090 | The `gravitino.uri` defines the connection URL of the Gravitino server, the default value is `http://localhost:8090`. Trino connector can detect and connect to Gravitino server once it is ready, no need to start Gravitino server beforehand. | Yes | 0.2.0 |
4 changes: 2 additions & 2 deletions docs/trino-connector/installation.md
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ To configure Gravitino connector correctly, you need to put the following config

```text
connector.name=gravitino
gravitino.url=http://gravitino-server-host:8090
gravitino.uri=http://gravitino-server-host:8090
gravitino.metalake=test
```

Expand Down Expand Up @@ -129,4 +129,4 @@ system
test.jdbc-mysql
```

The catalog named 'test.jdbc-mysql' is the catalog that you created by gravitino server, and you can use it to access the mysql database like other Trino catalogs.
The catalog named 'test.jdbc-mysql' is the catalog that you created by gravitino server, and you can use it to access the mysql database like other Trino catalogs.

0 comments on commit d213576

Please sign in to comment.