fix comments

apache · Sep 6, 2024 · 3b36e37 · 3b36e37
1 parent 5edebdc
commit 3b36e37
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 11 deletions.
diff --git a/clients/client-java/src/main/java/org/apache/gravitino/client/FilesetCatalog.java b/clients/client-java/src/main/java/org/apache/gravitino/client/FilesetCatalog.java
@@ -247,7 +247,7 @@ public String getFileLocation(NameIdentifier ident, String subPath)
     CallerContext callerContext = CallerContext.CallerContextHolder.get();
 
     Map<String, String> params = new HashMap<>();
-    params.put("subPath", RESTUtils.encodeString(subPath));
+    params.put("sub_path", RESTUtils.encodeString(subPath));
     FileLocationResponse resp =
         restClient.get(
             formatFileLocationRequestPath(fullNamespace, ident.name()),
@@ -280,7 +280,7 @@ static String formatFileLocationRequestPath(Namespace ns, String name) {
         .append(RESTUtils.encodeString(ns.level(2)))
         .append("/filesets/")
         .append(RESTUtils.encodeString(name))
-        .append("/fileLocation")
+        .append("/location")
         .toString();
   }
 

diff --git a/clients/client-java/src/test/java/org/apache/gravitino/client/TestFilesetCatalog.java b/clients/client-java/src/test/java/org/apache/gravitino/client/TestFilesetCatalog.java
@@ -424,7 +424,7 @@ public void testGetFileLocation() throws JsonProcessingException {
             FilesetCatalog.formatFileLocationRequestPath(
                 Namespace.of(metalakeName, catalogName, "schema1"), fileset.name()));
     Map<String, String> queryParams = new HashMap<>();
-    queryParams.put("subPath", RESTUtils.encodeString(mockSubPath));
+    queryParams.put("sub_path", RESTUtils.encodeString(mockSubPath));
 
     String mockFileLocation =
         String.format("file:/fileset/%s/%s/%s/%s", catalogName, "schema1", "fileset1", mockSubPath);
@@ -449,7 +449,7 @@ public void testCallerContextToHeader() throws JsonProcessingException {
             FilesetCatalog.formatFileLocationRequestPath(
                 Namespace.of(metalakeName, catalogName, "schema1"), fileset.name()));
     Map<String, String> queryParams = new HashMap<>();
-    queryParams.put("subPath", RESTUtils.encodeString(mockSubPath));
+    queryParams.put("sub_path", RESTUtils.encodeString(mockSubPath));
     String mockFileLocation =
         String.format("file:/fileset/%s/%s/%s/%s", catalogName, "schema1", "fileset1", mockSubPath);
     FileLocationResponse resp = new FileLocationResponse(mockFileLocation);

diff --git a/docs/open-api/filesets.yaml b/docs/open-api/filesets.yaml
@@ -157,7 +157,7 @@ paths:
         "5xx":
           $ref: "./openapi.yaml#/components/responses/ServerErrorResponse"
 
-  /metalakes/{metalake}/catalogs/{catalog}/schemas/{schema}/filesets/{fileset}/fileLocation:
+  /metalakes/{metalake}/catalogs/{catalog}/schemas/{schema}/filesets/{fileset}/location:
     parameters:
       - $ref: "./openapi.yaml#/components/parameters/metalake"
       - $ref: "./openapi.yaml#/components/parameters/catalog"
@@ -166,12 +166,12 @@ paths:
 
     get:
       tags:
-        - fileLocation
+        - location
       summary: Get file location
       operationId: getFileLocation
       description: Returns the specified file location object
       parameters:
-        - name: subPath
+        - name: sub_path
           in: query
           required: true
           schema:

diff --git a/server/src/main/java/org/apache/gravitino/server/web/rest/FilesetOperations.java b/server/src/main/java/org/apache/gravitino/server/web/rest/FilesetOperations.java
@@ -252,7 +252,7 @@ public Response dropFileset(
   }
 
   @GET
-  @Path("{fileset}/fileLocation")
+  @Path("{fileset}/location")
   @Produces("application/vnd.gravitino.v1+json")
   @Timed(name = "get-file-location." + MetricNames.HTTP_PROCESS_DURATION, absolute = true)
   @ResponseMetered(name = "get-file-location", absolute = true)
@@ -261,7 +261,7 @@ public Response getFileLocation(
       @PathParam("catalog") String catalog,
       @PathParam("schema") String schema,
       @PathParam("fileset") String fileset,
-      @QueryParam("subPath") @NotNull String subPath) {
+      @QueryParam("sub_path") @NotNull String subPath) {
     LOG.info(
         "Received get file location request: {}.{}.{}.{}, sub path:{}",
         metalake,

diff --git a/server/src/test/java/org/apache/gravitino/server/web/rest/TestFilesetOperations.java b/server/src/test/java/org/apache/gravitino/server/web/rest/TestFilesetOperations.java
@@ -439,8 +439,8 @@ public void testGetFileLocation() {
 
     when(dispatcher.getFileLocation(any(), any())).thenReturn(actualPath);
     Response resp =
-        target(filesetPath(metalake, catalog, schema) + "fileset1/fileLocation")
-            .queryParam("subPath", RESTUtils.encodeString("test/1"))
+        target(filesetPath(metalake, catalog, schema) + "fileset1/location")
+            .queryParam("sub_path", RESTUtils.encodeString("test/1"))
             .request(MediaType.APPLICATION_JSON_TYPE)
             .accept("application/vnd.gravitino.v1+json")
             .get();