Skip to content

Commit

Permalink
Fix
Browse files Browse the repository at this point in the history
  • Loading branch information
yuqi1129 committed Oct 14, 2024
1 parent 9edfe82 commit 3079bf0
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1187,7 +1187,6 @@ private Fileset createFileset(
if (catalogPath != null) {
props.put(HadoopCatalogPropertiesMetadata.LOCATION, catalogPath);
}
props.put(HadoopCatalogPropertiesMetadata.DEFAULT_FS, "file:///");

try (SecureHadoopCatalogOperations ops = new SecureHadoopCatalogOperations(store)) {
ops.initialize(props, randomCatalogInfo("m1", "c1"), HADOOP_PROPERTIES_METADATA);
Expand Down
3 changes: 1 addition & 2 deletions clients/client-python/tests/integration/test_catalog.py
Original file line number Diff line number Diff line change
Expand Up @@ -154,8 +154,7 @@ def test_load_catalog(self):
self.assertEqual(catalog.name(), self.catalog_name)
self.assertEqual(catalog.comment(), self.catalog_comment)
self.assertEqual(
catalog.properties(),
{self.catalog_location_prop: "/tmp/test_schema"},
catalog.properties(), {self.catalog_location_prop: "/tmp/test_schema"}
)
self.assertEqual(catalog.audit_info().creator(), "anonymous")

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -254,9 +254,7 @@ def test_get_file_location(self):
.get_file_location(fileset_ident, "/test/test.txt")
)

self.assertEqual(
actual_file_location, "/tmp/test_get_file_location/test/test.txt"
)
self.assertEqual(actual_file_location, f"file:{fileset_location}/test/test.txt")

# test rename without sub path should throw an exception
caller_context = CallerContext(
Expand Down
2 changes: 1 addition & 1 deletion docs/hadoop-catalog.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ Besides the [common catalog properties](./gravitino-server-config.md#gravitino-c
|----------------------------------------------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|---------------|-------------------------------------------------------------|---------------|
| `location` | The storage location managed by Hadoop catalog. | (none) | No | 0.5.0 |
| `filesystem-providers` | The filesystem providers for the Hadoop catalog. Gravitino already support `local file` and `hdfs`, if you want to support other file system, you can implement `FileSystemProvider` and set this value | (none) | No | 0.7.0 |
| `default-filesystem-provider` | The default file system of this Hadoop catalog. The value of this can be 'file', 'hdfs' currently. | (none) | No | 0.7.0 |
| `default-filesystem-provider` | The default file system provider this Hadoop catalog. The value of this can be 'file', 'hdfs' currently, more information please refer to `filesystem-providers` | (none) | No | 0.7.0 |
| `authentication.impersonation-enable` | Whether to enable impersonation for the Hadoop catalog. | `false` | No | 0.5.1 |
| `authentication.type` | The type of authentication for Hadoop catalog, currently we only support `kerberos`, `simple`. | `simple` | No | 0.5.1 |
| `authentication.kerberos.principal` | The principal of the Kerberos authentication | (none) | required if the value of `authentication.type` is Kerberos. | 0.5.1 |
Expand Down

0 comments on commit 3079bf0

Please sign in to comment.