[Improvement] Add support for curl and wget #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested by uninstalling wget and running the |
qqqttt123
reviewed
Jan 17, 2024
| echo "Start to download the jar package of JDBC" | ||
| wget https://repo1.maven.org/maven2/mysql/mysql-connector-java/8.0.27/mysql-connector-java-8.0.27.jar -O /root/gravitino/catalogs/jdbc-mysql/libs/mysql-connector-java-8.0.27.jar | ||
| wget https://jdbc.postgresql.org/download/postgresql-42.7.0.jar -O /root/gravitino/catalogs/jdbc-postgresql/libs/postgresql-42.7.0.jar | ||
| echo "Downloading the JDBC drivers for MySQL and PostgreSQL" |
There was a problem hiding this comment.
This shell should be executed in the Docker image, too. So I guess the issue isn't caused by the absence of wget.
|
I am a little confused by what going on here but without wget installed the launch playground script fails. I can't see where it uses wget but it fails, users have also reported this and have fixed it by installing wget. If you install wget or have the above changes it works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
macOS doesn't have wget installed by default, and the playground script fails silently if wget is not installed. Add support for wget and curl and print out a meaningful error message if neither can be found. This fixes #20.