Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GEODE-10088: serverGroups support #941

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

GEODE-10088: serverGroups support #941

wants to merge 2 commits into from

Conversation

mmartell
Copy link
Contributor

@mmartell mmartell commented Mar 3, 2022

Adds serverGroups to new clicache test framework.

@mmartell
GEODE-10088: serverGroups support
a7cedfb 
- add to new clicache test framework
@mmartell mmartell requested a review from pdxcodemonkey March 3, 2022 07:09
pdxcodemonkey
pdxcodemonkey requested changes Mar 3, 2022
View reviewed changes
Copy link
Contributor

@pdxcodemonkey pdxcodemonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add at least one trivial integration test that exercises this code. Thanks for adding this, it will be helpful to improve our test coverage!

@mmartell
Copy link
Contributor Author

mmartell commented Apr 7, 2022

Please add at least one trivial integration test that exercises this code. Thanks for adding this, it will be helpful to improve our test coverage!

Modififed the existing StartServerStringsTest (in new test framework) to validate that .withGroups() adds the --groups arg to start server command.

Also, we already have tests that exercise the --groups functionality on the client side: testXmlCacheCreationWithPools

@mmartell mmartell requested a review from pdxcodemonkey April 7, 2022 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdxcodemonkey pdxcodemonkey Awaiting requested review from pdxcodemonkey

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmartell @pdxcodemonkey