GEODE-4728 - Update defaultSystem/geode.properties #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jake-at-work
requested changes
Apr 13, 2018
defaultSystem/geode.properties
Outdated
| @@ -12,7 +12,7 @@ | |||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | |||
| # See the License for the specific language governing permissions and | |||
| # limitations under the License. | |||
| # Default Gemfire C++ distributed system properties | |||
| # Default C++ distributed system properties | |||
There was a problem hiding this comment.
These properties are also loaded by the .NET client. I wonder if we can give them a better name.
There was a problem hiding this comment.
Maybe it is just Default Geode distributed systems properties? That way there is no reference to C++ or .NET
There was a problem hiding this comment.
Geode Native probably. This file shouldn't get confused with the one for the Java client/server.
defaultSystem/geode.properties
Outdated
| # | ||
| #cache-xml-file=cache.xml | ||
| # | ||
| ## Log file config | ||
| # | ||
| #log-file=gemfire_cpp.log | ||
| #log-file=geode_cpp.log |
|
Hmm I thought it was GEODE-4728, but I may be off since I didn't realize it contained subtasks. |
|
@moleske please use the GEODE number in the PR title and at least the first commit message. |
moleske
changed the title
@davebarnes97 and I stumbled upon these when looking at some documentation
|
My bad, was on GitHub when we saw it and forgot to check Jira before blindly updating comments |
jake-at-work
approved these changes
Apr 13, 2018
jake-at-work
pushed a commit
to jake-at-work/geode-native
that referenced
this pull request
Oct 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@davebarnes97 and I stumbled upon these when looking at some documentation