fix(java): Move schema caching to unsafe trait to avoid issues when using non-inferred schema. #1944
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR removes the java specific
ExtField
class from the schema and moves the extData mechanism to the internal UnsafeTrait class. This is necessary becauseExtField
is only created internally frominferSchema
method used by java, and we would potentially import or derive schemas from other sources (e.g XLANG, handwritten schema, arrow-native source) -- those schemas will be incompatible when we attempt to retrieve the cached schema. Removing schema-caching will fix the issue, but create allocations, so after some discussion, we decided to move the mechanism to the internal UnsafeTrait class.This implementation makes changes internal API:
UnsafeTrait
need to initialize theextData
cache and define the number of extData slots needed.getStruct
method needs to define which slot we use to retrieveextData
.Other:
Related issues
Does this PR introduce any user-facing change?
N/A
Benchmark