feat(java): Support copy capabilities for some classes without no-argument constructors #1794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…no_arg_class_copy
…ub.com/zhaommmmomo/fury into feat/support_without_no_arg_class_copy
chaokunyang
reviewed
Aug 7, 2024
| @Override | ||
| public Object copy(Object value) { | ||
| Serializer serializer = classClassInfoHolderMap.get(value.getClass()).objectSerializer; | ||
| return fury.copyObject(value, serializer); |
There was a problem hiding this comment.
Do we need to invoke resolve method?
chaokunyang
reviewed
Aug 7, 2024
| @@ -439,6 +441,28 @@ protected <K, V> void copyEntry(Map<K, V> originMap, Map<K, V> newMap) { | |||
| } | |||
| } | |||
|
|
|||
| protected <K, V> void copyEntry(Map<K, V> originMap, Builder<K, V> builder) { | |||
There was a problem hiding this comment.
If we overwrite this method, we shoud add @Override annotation
chaokunyang
reviewed
Aug 7, 2024
| @Override | ||
| public T copy(T originCollection) { | ||
| if (slotsSerializers.length == 0) { | ||
| return super.copy(originCollection); |
There was a problem hiding this comment.
This will return an object of super class type, which is not right
chaokunyang
reviewed
Aug 7, 2024
| if (slotsSerializers.length == 0) { | ||
| return super.copy(originCollection); | ||
| } | ||
| return (T) slotsSerializers[0].copy(originCollection); |
There was a problem hiding this comment.
This return an object of first field
chaokunyang
reviewed
Aug 7, 2024
|
|
||
| @Override | ||
| public T copy(T originMap) { | ||
| if (slotsSerializers.length == 0) { |
chaokunyang
reviewed
Aug 7, 2024
| @@ -79,6 +79,21 @@ public void copyElements(T originCollection, Collection newCollection) { | |||
| } | |||
| } | |||
|
|
|||
| public void copyElements(T originCollection, Object[] elements) { | |||
There was a problem hiding this comment.
add @Override annotation
chaokunyang
reviewed
Aug 8, 2024
| @Override | ||
| public ByteBuffer copy(ByteBuffer value) { | ||
| ByteBuffer dst = ByteBuffer.allocate(value.capacity()); | ||
| dst.put(value); |
There was a problem hiding this comment.
Suggested change
| dst.put(value); | |
| dst.put(value.duplicate()); |
We need to duplicate, otherwise it will update offset in ByteBuffer
chaokunyang
reviewed
Aug 8, 2024
| @@ -44,6 +44,13 @@ public void write(MemoryBuffer buffer, ByteBuffer value) { | |||
| fury.writeBufferObject(buffer, new BufferObject.ByteBufferBufferObject(value)); | |||
| } | |||
|
|
|||
| @Override | |||
| public ByteBuffer copy(ByteBuffer value) { | |||
| ByteBuffer dst = ByteBuffer.allocate(value.capacity()); | |||
There was a problem hiding this comment.
Suggested change
| ByteBuffer dst = ByteBuffer.allocate(value.capacity()); | |
| ByteBuffer dst = ByteBuffer.allocate(value.remaining()); |
chaokunyang
reviewed
Aug 8, 2024
| Preconditions.checkNotNull(interfaces); | ||
| Preconditions.checkNotNull(invocationHandler); | ||
| Object proxy = Proxy.newProxyInstance(fury.getClassLoader(), interfaces, STUB_HANDLER); | ||
| Platform.putObject(proxy, PROXY_HANDLER_FIELD_OFFSET, invocationHandler); |
There was a problem hiding this comment.
Suggested change
| Platform.putObject(proxy, PROXY_HANDLER_FIELD_OFFSET, invocationHandler); | |
| Object proxy = Proxy.newProxyInstance(fury.getClassLoader(), interfaces, STUB_HANDLER); | |
| fury.reference(value, proxy); | |
| Platform.putObject(proxy, PROXY_HANDLER_FIELD_OFFSET, | |
| fury.copyObject(invocationHandler)); |
chaokunyang
reviewed
Aug 8, 2024
| @@ -542,6 +542,35 @@ public Collection newCollection() { | |||
| } | |||
| } | |||
|
|
|||
| public void copyElements(Collection originCollection, Collection newCollection) { | |||
There was a problem hiding this comment.
CollectionSerializer has same method, could we remove that method?
chaokunyang
reviewed
Aug 8, 2024
| @Override | ||
| public T copy(T originCollection) { | ||
| if (objectSerializer == null) { | ||
| objectSerializer = new ObjectSerializer<>(fury, type, false); |
There was a problem hiding this comment.
Could we update ObjectSerializer:
public ObjectSerializer(Fury fury, Class<T> cls, boolean resolveParent) {
super(fury, cls);
// avoid recursive building serializers.
// Use `setSerializerIfAbsent` to avoid overwriting existing serializer for class when used
// as data serializer.
if (resolveParent) {
classResolver.setSerializerIfAbsent(cls, this);
}
chaokunyang
reviewed
Aug 8, 2024
|
Very nice work, thank you @zhaommmmomo |
chaokunyang
approved these changes
Aug 13, 2024
There was a problem hiding this comment.
LGTM, this is not an easy work, thanks for your contribution @zhaommmmomo
This is what I should do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Some classes with no-argument constructors will report an error when calling
copy().This pr:
Related issues
#1777
#1679
Does this PR introduce any user-facing change?
Benchmark