Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(java): Fix memory leak in StructSerializer.xread() caused by re-pushing instead of popping GenericType. #1768

Merged
merged 1 commit into from
Jul 27, 2024
Merged

fix(java): Fix memory leak in StructSerializer.xread() caused by re-pushing instead of popping GenericType. #1768

merged 1 commit into from
Jul 27, 2024

Conversation

komamitsu
Copy link
Contributor

What does this PR do?

Fix memory leak in StructSerializer.xread() caused by re-pushing instead of popping GenericType.

Related issues

None, probably.

Does this PR introduce any user-facing change?

  • Does this PR introduce any public API change?
  • Does this PR introduce any binary protocol compatibility change?

Benchmark

N/A

@komamitsu komamitsu requested a review from chaokunyang as a code owner July 27, 2024 07:37
chaokunyang
chaokunyang approved these changes Jul 27, 2024
View reviewed changes
Copy link
Collaborator

@chaokunyang chaokunyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks

@chaokunyang chaokunyang merged commit beb0797 into apache:main Jul 27, 2024
32 checks passed
@komamitsu komamitsu deleted the fix_generics_leak_on_xread branch July 27, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaokunyang chaokunyang chaokunyang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@komamitsu @chaokunyang