Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(java): rename blacklist/whitelist to allowed/disallowed list #1449

Merged
merged 1 commit into from
Apr 1, 2024
Merged

chore(java): rename blacklist/whitelist to allowed/disallowed list #1449

merged 1 commit into from
Apr 1, 2024

Conversation

chaokunyang
Copy link
Collaborator

Closes #1447

@chaokunyang chaokunyang requested review from theweipeng, tisonkun, PragmaTwice and pjfanning and removed request for theweipeng and PragmaTwice April 1, 2024 15:29
LiangliangSui
LiangliangSui approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@LiangliangSui LiangliangSui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pjfanning
pjfanning approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - LGTM

@chaokunyang chaokunyang merged commit a4356eb into apache:main Apr 1, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiangliangSui LiangliangSui LiangliangSui approved these changes

@pjfanning pjfanning pjfanning approved these changes

@theweipeng theweipeng Awaiting requested review from theweipeng theweipeng is a code owner

@tisonkun tisonkun Awaiting requested review from tisonkun

@PragmaTwice PragmaTwice Awaiting requested review from PragmaTwice PragmaTwice is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rename blacklist code
3 participants
@chaokunyang @pjfanning @LiangliangSui