Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(java): Allow partial read of serialized size from InputStream #1391

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Conversation

phogh
Copy link
Contributor

@phogh phogh commented Feb 29, 2024

Deserialize from InputStream throws when the size cannot be read in one read. This fixes the issue by reading in a loop like it does for the serialized data.

Closes #1383

Remove assumption of a complete read of serialized size in `Fury#readToBufferFromStream` and refactor the read loop.
@phogh phogh requested a review from chaokunyang as a code owner February 29, 2024 10:50
Copy link
Collaborator

@chaokunyang chaokunyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution, @phogh

@chaokunyang chaokunyang merged commit d9198e7 into apache:main Feb 29, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deserialize from InputStream allowing for partial reads
2 participants