Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(JavaScript): enhance performance 64bits number #1320

Merged
merged 5 commits into from
Jan 9, 2024
Merged

feat(JavaScript): enhance performance 64bits number #1320

merged 5 commits into from
Jan 9, 2024

Conversation

theweipeng
Copy link
Member

  1. Creating BigInts is too performance-intensive; we'll use uint32 instead.
  2. Reduce memory reads as much as possiable; Replace calle uint8 four times by uint32 once.

@theweipeng theweipeng requested a review from chaokunyang January 8, 2024 05:55
chaokunyang
chaokunyang approved these changes Jan 9, 2024
View reviewed changes
Copy link
Collaborator

@chaokunyang chaokunyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theweipeng theweipeng merged commit a80dce6 into apache:main Jan 9, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaokunyang chaokunyang chaokunyang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theweipeng @chaokunyang