-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(javascript): Refactor & Compress Long #1313
Conversation
4c3d57a
to
8284cd5
Compare
feature: refactor to enhancement
8284cd5
to
f175831
Compare
fantasitic work, this is the thing I wanted of a serialization framework |
Looks good to me, but has some typo. And we can improve the style of generated code, this can be done in further |
I fixed it and added an afterCodeGenerated hook to allow users to format the code. Formatting is not a default action, as I believe we should keep things simple and avoid including too many dependencies. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Refactor the code generator
Enhancement performance
Improve
When useSliceString is disabled, the performance of deserialization improves by 100%. It is 3 times faster than native JSON and twice as fast as protobuf.
When useSliceString is enabled, the performance of deserialization improves by 30%. It is 5 times faster than native JSON and 3 times faster than protobuf.
Before:
Disable useSliceString
Enable useSliceString
After:
Disable useSliceString
Enable useSliceString