Update NOTICE to mention all the licenses for source files where code is borrowed from different project. #1285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… code is borrowed from different project
|
Seems like a good start to me. I suspect we might need tidy up and possibly some more additions but this could probably be merged as is to get us started. |
chaokunyang
reviewed
Dec 30, 2023
PragmaTwice
reviewed
Dec 31, 2023
nandakumar131
force-pushed
the
update-fury-license
branch
from
1b2cd26 to
6692c48
Compare
tisonkun
reviewed
Jan 3, 2024
There was a problem hiding this comment.
@nandakumar131 can you elaborate how this file generated?
There was a problem hiding this comment.
This is a copy of the LICENSE from nodejs/node.
https://github.com/nodejs/node/blob/main/LICENSE
This is mentioned in the NOTICE file
The following components are provided under the Node.js License. See project link for details.
The text of each license is also included in licenses/LICENSE-[project].txt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1274