Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java] Support registration in thread safe fury #1280

Merged
merged 7 commits into from
Dec 29, 2023
Merged

[Java] Support registration in thread safe fury #1280

merged 7 commits into from
Dec 29, 2023

Conversation

chaokunyang
Copy link
Collaborator

Closes #1279

tisonkun
tisonkun reviewed Dec 29, 2023
View reviewed changes
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the technical part,

pjfanning
pjfanning requested changes Dec 29, 2023
View reviewed changes
Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Graal VM check is failing

@chaokunyang
Copy link
Collaborator Author

CI has been fixed

pjfanning
pjfanning approved these changes Dec 29, 2023
View reviewed changes
Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chaokunyang chaokunyang merged commit bdada2d into apache:main Dec 29, 2023
16 checks passed
@chaokunyang chaokunyang deleted the support_registration_in_thread_safe_fury branch April 1, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisonkun tisonkun tisonkun approved these changes

@pjfanning pjfanning pjfanning approved these changes

@theweipeng theweipeng Awaiting requested review from theweipeng

@PragmaTwice PragmaTwice Awaiting requested review from PragmaTwice

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Java] support class registration in ThreadSafeFury
3 participants
@chaokunyang @pjfanning @tisonkun