[Java] Maximum size of Java arrays is not correct #1842
Labels
bug
Something isn't working
Comments
2 tasks
fink-arthur
changed the title
chaokunyang
pushed a commit
that referenced
this issue
Sep 13, 2024
## What does this PR do? Fixes the maximum size of Java arrays using Integer.MAX_VALUE when it should be Integer.MAX_VALUE - 8. See this https://github.com/openjdk/jdk14u/blob/84917a040a81af2863fddc6eace3dda3e31bf4b5/src/java.base/share/classes/jdk/internal/util/ArraysSupport.java#L577 or https://www.baeldung.com/java-arrays-max-size ## Related issues - #1842 ## Does this PR introduce any user-facing change? No - [ ] Does this PR introduce any public API change? No - [ ] Does this PR introduce any binary protocol compatibility change? No ## Benchmark <!-- When the PR has an impact on performance (if you don't know whether the PR will have an impact on performance, you can submit the PR first, and if it will have impact on performance, the code reviewer will explain it), be sure to attach a benchmark data here. --> Co-authored-by: Arthur Finkelstein <[email protected]>
2 tasks
chaokunyang
pushed a commit
that referenced
this issue
Sep 14, 2024
## What does this PR do? Fixes the maximum size of Java arrays using Integer.MAX_VALUE when it should be Integer.MAX_VALUE - 8. See this https://github.com/openjdk/jdk14u/blob/84917a040a81af2863fddc6eace3dda3e31bf4b5/src/java.base/share/classes/jdk/internal/util/ArraysSupport.java#L577 or https://www.baeldung.com/java-arrays-max-size Same as #1843 but for the reader. ## Related issues - #1842 ## Does this PR introduce any user-facing change? No - [ ] Does this PR introduce any public API change? No - [ ] Does this PR introduce any binary protocol compatibility change? No ## Benchmark Not needed Co-authored-by: Arthur Finkelstein <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Search before asking
Version
8.1.0
Component(s)
Java
Minimal reproduce step
MemoryBuffer memoryBuffer = MemoryBuffer.newHeapBuffer(10);memoryBuffer.grow(Integer.MAX_VALUE);What did you expect to see?
A MemoryBuffer of the maximum size
What did you see instead?
java.lang.OutOfMemoryError: Requested array size exceeds VM limitAnything Else?
No response
Are you willing to submit a PR?
The text was updated successfully, but these errors were encountered: