Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider to remove CODEOWNERS #1296

Closed
PragmaTwice opened this issue Jan 3, 2024 · 5 comments
Closed

Consider to remove CODEOWNERS #1296

PragmaTwice opened this issue Jan 3, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@PragmaTwice
Copy link
Member

It is outdated and from my view it is unnecessary to keep.
@PragmaTwice PragmaTwice added the enhancement New feature or request label Jan 3, 2024
@chaokunyang
Copy link
Collaborator

Projects like apache/arrow still have such configurations:
image

It may be useful for some new contributors to ask someone for review code

@PragmaTwice
Copy link
Member Author

But in the current CODEOWNERS, just one ID chaokunyang is valid, it's useless.

If you want to add, you can add a new version after deleting the current one.

@liuxiaocs7
Copy link
Member

Hi, @PragmaTwice and @chaokunyang

seems incorrect user id results invalid file

image

@liuxiaocs7 liuxiaocs7 mentioned this issue Jan 5, 2024
Merged
@chaokunyang
Copy link
Collaborator

chaokunyang commented Jan 5, 2024 •
edited
Loading

But in the current CODEOWNERS, just one ID chaokunyang is valid, it's useless.

If you want to add, you can add a new version after deleting the current one.

It's out-dated, we should update it. But if it did not help with code review, then we should remove it.

chaokunyang pushed a commit that referenced this issue Jan 5, 2024
@liuxiaocs7
[MINOR] Update CODEOWNERS (#1312)
6068cf0 
refer: #1296
theweipeng pushed a commit to theweipeng/fury that referenced this issue Jan 6, 2024
@liuxiaocs7 @theweipeng
[MINOR] Update CODEOWNERS (apache#1312)
9f07753 
refer: apache#1296
@chaokunyang chaokunyang mentioned this issue Jan 6, 2024
Merged
chaokunyang added a commit that referenced this issue Jan 6, 2024
@chaokunyang @PragmaTwice
chore: Update CODEOWNERS (#1316)
f49e662 
Update code reviewer for cpp module, see more in #1296

---------

Co-authored-by: Twice <[email protected]>
@chaokunyang
Copy link
Collaborator

Closed for now, feel free to reopen it if current review mechanism does't meet the community requirements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chaokunyang @PragmaTwice @liuxiaocs7