Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CODE HEADERS] Can we remove the author tags from the Fury code covered by the code grant? #1281

Closed
pjfanning opened this issue Dec 29, 2023 · 6 comments · Fixed by #1282
Closed
Labels
enhancement New feature or request

Comments

@pjfanning
Copy link
Contributor

It appears to be unusual to have author tags in ASF code bases. There are exceptions for code that is borrowed from 3rd party sources - if it was not explicitly granted to the ASF.

@pjfanning pjfanning added the enhancement New feature or request label Dec 29, 2023
@chaokunyang
Copy link
Collaborator

Hi PJ, do you mean the java doc author tag like:

/**
 * Thread safe serializer interface. {@link Fury} is not thread-safe, the implementation of this
 * interface will be thread-safe. And support switch classloader dynamically.
 *
 * @author chaokunyang
 */

@chaokunyang
Copy link
Collaborator

We have such tags before joining ASF. If it's not recommanded, I can create a PR to remove it all

@pjfanning
Copy link
Contributor Author

pjfanning commented Dec 29, 2023

Yes - it is the @author tags that I am referring to.

The ASF likes the idea of collective code owenership. The git history and git blame give a good idea of authorship anyway.

@chaokunyang
Copy link
Collaborator

Will be removed in #1282

@pjfanning
Copy link
Contributor Author

https://whimsy.apache.org/board/minutes/Confirming_that_the_current_stance_on__author_tags_as.html

It is a recommendation (strong one) that the tags are removed but the PPMC could decide to allow them, if people are very attached to them.

@chaokunyang
Copy link
Collaborator

I think tags can be removed. Currently only java code contains @author.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants