Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java][License] GPLv2 license of jmh benchmark tool conflict with ASF's license policy #1271

Closed
chaokunyang opened this issue Dec 28, 2023 · 0 comments · Fixed by #1272
Closed

[Java][License] GPLv2 license of jmh benchmark tool conflict with ASF's license policy #1271

chaokunyang opened this issue Dec 28, 2023 · 0 comments · Fixed by #1272
Labels
enhancement New feature or request

Comments

@chaokunyang
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

fury-benchmark and perftests use https://github.com/openjdk/jmh for benchmark tests.

JMH is licensed under GPLv2, which doesn't comply with ASF's license policy when releasing source/binary packages, even though Fury just refers to some "org.openjdk.jmh."

Describe the solution you'd like

According to apache license doc: https://www.apache.org/legal/resolved.html#optional
image

If we make jmh dependency as optional, we can use such dependencies.

Additional context

https://lists.apache.org/thread/qcxd26yhmx27k5gr4jgrlx6hck6fcsdy
@chaokunyang chaokunyang added the enhancement New feature or request label Dec 28, 2023
@chaokunyang chaokunyang mentioned this issue Dec 28, 2023
Merged
chaokunyang added a commit that referenced this issue Jan 2, 2024
@chaokunyang
[Java] Fix fury benchmark jmh GPLV2 license conflict (#1272)
1134cce 
This PR closes #1271  by:
- Remove java/fury-benchmark from fury java module. In this way, when
users/developers compiles and install fury from source, jmh won't be
downloaded by default.
- Make jmh depdendency as optional, and only avlaiable when activating
`jmh` profile.

According to apache license doc:
https://www.apache.org/legal/resolved.html#optional

![image](https://github.com/apache/incubator-fury/assets/12445254/bd5cc989-2911-4d43-81da-9b2dd9c4e0c3)

I believe GPLv2 license conflict has been addressed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Java] Fix fury benchmark jmh GPLV2 license conflict chaokunyang/fury
1 participant
@chaokunyang