-
Notifications
You must be signed in to change notification settings - Fork 258
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(JavaScript): Implement Enum (#1321)
Implement the Enum type which declare in SPEC. Usage: ```TypeScript enum Foo { f1 = 1, f2 = 2 } const fury = new Fury({ refTracking: true }); const {serialize, deserialize} = fury.registerSerializer(Type.enum(Foo)) const input = serialize(Foo.f1); const result = deserialize( input ); expect(result).toEqual(Foo.f1) ```
- Loading branch information
1 parent
bf092cf
commit a07bf8c
Showing
6 changed files
with
205 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,88 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
import { EnumTypeDescription, TypeDescription } from "../description"; | ||
import { CodecBuilder } from "./builder"; | ||
import { BaseSerializerGenerator } from "./serializer"; | ||
import { CodegenRegistry } from "./router"; | ||
import { InternalSerializerType, MaxUInt32 } from "../type"; | ||
import { Scope } from "./scope"; | ||
|
||
class EnumSerializerGenerator extends BaseSerializerGenerator { | ||
description: EnumTypeDescription; | ||
|
||
constructor(description: TypeDescription, builder: CodecBuilder, scope: Scope) { | ||
super(description, builder, scope); | ||
this.description = <EnumTypeDescription>description; | ||
} | ||
|
||
writeStmt(accessor: string): string { | ||
if (Object.values(this.description.options.inner).length < 1) { | ||
throw new Error("An enum must contain at least one field"); | ||
} | ||
return ` | ||
${Object.values(this.description.options.inner).map((value, index) => { | ||
if (typeof value !== "string" && typeof value !== "number") { | ||
throw new Error("Enum value must be string or number"); | ||
} | ||
if (typeof value === "number") { | ||
if (value > MaxUInt32 || value < 0) { | ||
throw new Error("Enum value must be a valid uint32"); | ||
} | ||
} | ||
const safeValue = typeof value === "string" ? `"${value}"` : value; | ||
return ` if (${accessor} === ${safeValue}) { | ||
${this.builder.writer.varUInt32(index)} | ||
}`; | ||
}).join(" else ")} | ||
else { | ||
throw new Error("Enum received an unexpected value: " + ${accessor}); | ||
} | ||
`; | ||
} | ||
|
||
readStmt(accessor: (expr: string) => string): string { | ||
const enumValue = this.scope.uniqueName("enum_v"); | ||
return ` | ||
const ${enumValue} = ${this.builder.reader.varUInt32()}; | ||
switch(${enumValue}) { | ||
${Object.values(this.description.options.inner).map((value, index) => { | ||
if (typeof value !== "string" && typeof value !== "number") { | ||
throw new Error("Enum value must be string or number"); | ||
} | ||
if (typeof value === "number") { | ||
if (value > MaxUInt32 || value < 0) { | ||
throw new Error("Enum value must be a valid uint32"); | ||
} | ||
} | ||
const safeValue = typeof value === "string" ? `"${value}"` : `${value}`; | ||
return ` | ||
case ${index}: | ||
${accessor(safeValue)} | ||
break; | ||
`; | ||
}).join("\n")} | ||
default: | ||
throw new Error("Enum received an unexpected value: " + enumValue); | ||
} | ||
`; | ||
} | ||
} | ||
|
||
CodegenRegistry.register(InternalSerializerType.ENUM, EnumSerializerGenerator); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,80 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
import Fury, { TypeDescription, InternalSerializerType, Type } from '../packages/fury/index'; | ||
import {describe, expect, test} from '@jest/globals'; | ||
|
||
describe('enum', () => { | ||
test('should javascript number enum work', () => { | ||
const Foo = { | ||
f1: 1, | ||
f2: 2 | ||
} | ||
const fury = new Fury({ refTracking: true }); | ||
const {serialize, deserialize} = fury.registerSerializer(Type.enum(Foo)) | ||
const input = serialize(Foo.f1); | ||
const result = deserialize( | ||
input | ||
); | ||
expect(result).toEqual(Foo.f1) | ||
}); | ||
|
||
test('should javascript string enum work', () => { | ||
const Foo = { | ||
f1: "hello", | ||
f2: "world" | ||
} | ||
const fury = new Fury({ refTracking: true }); | ||
fury.registerSerializer(Type.enum(Foo)) | ||
const input = fury.serialize(Foo.f1); | ||
const result = fury.deserialize( | ||
input | ||
); | ||
expect(result).toEqual(Foo.f1) | ||
}); | ||
test('should typescript number enum work', () => { | ||
enum Foo { | ||
f1 = 1, | ||
f2 = 2 | ||
} | ||
const fury = new Fury({ refTracking: true }); | ||
const {serialize, deserialize} = fury.registerSerializer(Type.enum(Foo)) | ||
const input = serialize(Foo.f1); | ||
const result = deserialize( | ||
input | ||
); | ||
expect(result).toEqual(Foo.f1) | ||
}); | ||
|
||
test('should typescript string enum work', () => { | ||
enum Foo { | ||
f1 = "hello", | ||
f2 = "world" | ||
} | ||
const fury = new Fury({ refTracking: true }); | ||
fury.registerSerializer(Type.enum(Foo)) | ||
const input = fury.serialize(Foo.f1); | ||
const result = fury.deserialize( | ||
input | ||
); | ||
expect(result).toEqual(Foo.f1) | ||
}); | ||
}); | ||
|
||
|