Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.20][FLINK-37100][tests] Fix test_netty_shuffle_memory_control.sh in CI for JDK11+ #25955

Open
wants to merge 1 commit into
base: release-1.20
Choose a base branch
from

Conversation

ferenc-csaky
Copy link
Contributor

What is the purpose of the change

Fixes the test executed by test_netty_shuffle_memory_control.sh that can possibly fail the CI in case Netty4 cannot reserve enough memory, hence Pekko is not able to start up.

Brief change log

  • Set io.netty.tryReflectionSetAccessible=true for TMs, which reduces Netty4 memory footprint.

Verifying this change

Existing test should run consistently.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? handled in different PR

@ferenc-csaky ferenc-csaky changed the title [FLINK-37100][tests] Fix test_netty_shuffle_memory_control.sh in CI for JDK11+ [1.20][FLINK-37100][tests] Fix test_netty_shuffle_memory_control.sh in CI for JDK11+ Jan 10, 2025
@flinkbot
Copy link
Collaborator

flinkbot commented Jan 10, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants