Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-36422][docs] Fix PyFlink jar download link #123

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

z3d1k
Copy link
Contributor

@z3d1k z3d1k commented Oct 3, 2024

What is the purpose of the change

Fix PyFlink jar download link.

Brief change log

  • Use py_connector_download_link shortcode to generate link with correct connector artifact version, instead of Flink version.

Verifying this change

  • Generated documentation locally

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Copy link

boring-cyborg bot commented Oct 3, 2024

Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)

@dannycranmer dannycranmer merged commit ac8fa12 into apache:main Oct 3, 2024
11 of 13 checks passed
Copy link

boring-cyborg bot commented Oct 3, 2024

Awesome work, congrats on your first merged pull request!

@z3d1k z3d1k deleted the broken_download_link_python branch October 24, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants