[MongoDB CDC] Fix “pollAwaitTimeMillis” does not take effect #1994 #1995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jiabao-Sun
reviewed
Mar 15, 2023
There was a problem hiding this comment.
Thanks @liangyaohui97 for this contribution.
I left few comments.
...in/java/com/ververica/cdc/connectors/mongodb/source/reader/fetch/MongoDBStreamFetchTask.java
Outdated
Show resolved
Hide resolved
Jiabao-Sun
approved these changes
Mar 24, 2023
There was a problem hiding this comment.
Thanks @liangyaohui97 for the great work!
It LGTM in general. I made some changes about updating next update time because the heartbeat may also cost some time, using current time + time interval may be more accurate.
Jiabao-Sun
approved these changes
Mar 24, 2023
|
The use case of CI failure has nothing to do with this PR. |
2 tasks
rawlinxx
pushed a commit
to rawlinxx/flink-cdc-connectors
that referenced
this pull request
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.