Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Db2 cdc connector (cp from #450) #1626

Closed
wants to merge 5 commits into from
Closed

Support Db2 cdc connector (cp from #450) #1626

wants to merge 5 commits into from

Conversation

ruanhang1993
Copy link
Contributor

Support Db2 cdc connector , cherry pick from #450 .

@leonardBang leonardBang self-requested a review October 19, 2022 11:31
@leonardBang leonardBang requested review from GOODBOY008 and removed request for leonardBang October 26, 2022 14:17
@leonardBang
Copy link
Contributor

Thanks @ruanhang1993 for picking up the hanging task, @GOODBOY008 Would you like to take a look this PR？

GOODBOY008
GOODBOY008 reviewed Oct 27, 2022
View reviewed changes
Copy link
Member

@GOODBOY008 GOODBOY008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ruanhang1993 Thanks for your contributions. Should add e2e test and metadata columns support.

flink-connector-db2-cdc/src/main/java/com/ververica/cdc/connectors/db2/Db2Source.java Outdated Show resolved Hide resolved
flink-connector-db2-cdc/src/main/java/com/ververica/cdc/connectors/db2/Db2Source.java Outdated Show resolved Hide resolved
...nnector-db2-cdc/src/test/java/com/ververica/cdc/connectors/db2/table/Db2ConnectorITCase.java
}

@Test
public void testConsumingAllEvents()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should add timezone unit test.

Copy link
Contributor Author

@ruanhang1993 ruanhang1993 Oct 27, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually the time zone information for the timestamp types will not be contained in the debezium db2 connector. IMO this time zone setting may be useless.

...k-connector-db2-cdc/src/main/java/com/ververica/cdc/connectors/db2/table/StartupOptions.java Outdated Show resolved Hide resolved
flink-connector-db2-cdc/src/test/java/com/ververica/cdc/connectors/db2/Db2TestBase.java Outdated Show resolved Hide resolved
docs/content/connectors/db2-cdc.md Show resolved Hide resolved
GOODBOY008
GOODBOY008 reviewed Oct 29, 2022
View reviewed changes
Copy link
Member

@GOODBOY008 GOODBOY008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ruanhang1993 LGTM , @leonardBang Pls cc.

flink-cdc-e2e-tests/src/test/java/com/ververica/cdc/connectors/tests/Db2E2eITCase.java Outdated Show resolved Hide resolved
docs/content/connectors/db2-cdc.md Outdated Show resolved Hide resolved
...nector-db2-cdc/src/main/java/com/ververica/cdc/connectors/db2/table/Db2ReadableMetaData.java Show resolved Hide resolved
flink-connector-db2-cdc/src/test/java/com/ververica/cdc/connectors/db2/Db2TestBase.java Outdated Show resolved Hide resolved
@GOODBOY008
Copy link
Member

@ruanhang1993 DB2 unit test is not runned , you can modify file in directory tools/azure-pipelines and tools/ci.

GOODBOY008
GOODBOY008 approved these changes Oct 31, 2022
View reviewed changes
Copy link
Member

@GOODBOY008 GOODBOY008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

leonardBang
leonardBang approved these changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ruanhang1993 and @GOODBOY008 for the great work. LGTM, I've checked the tutorial it works well.

leonardBang pushed a commit that referenced this pull request Oct 31, 2022
@ruanhang1993 @leonardBang
[db2] Add sql connector for Db2 CDC (#1626)
3592dcc 
This closes #450.
@leonardBang
Copy link
Contributor

leonardBang commented Oct 31, 2022 •
edited
Loading

Implemented in 3592dcc

@ruanhang1993 ruanhang1993 deleted the db2 branch October 23, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GOODBOY008 GOODBOY008 GOODBOY008 approved these changes

@leonardBang leonardBang leonardBang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ruanhang1993 @leonardBang @GOODBOY008