Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] translate mysql cdc doc to Chinese.#1391 #1435

Closed
wants to merge 2 commits into from
Closed

[docs] translate mysql cdc doc to Chinese.#1391 #1435

wants to merge 2 commits into from

Conversation

gtk96
Copy link
Contributor

@gtk96 gtk96 commented Jul 31, 2022

This PR Main solutions #1391

@gtk96 gtk96 mentioned this pull request Jul 31, 2022
Closed
@leonardBang leonardBang self-requested a review August 1, 2022 04:25
leonardBang
leonardBang approved these changes Aug 1, 2022
View reviewed changes
Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @RookieGao for the contribution, LGTM. I also help improve a little.

@gtk96
Copy link
Contributor Author

gtk96 commented Aug 1, 2022

@leonardBang I have put forward some suggestions for improving the current document. If you agree, I will make corresponding changes at night, because I don't have a suitable environment to deal with it during the day

@leonardBang
Copy link
Contributor

@leonardBang I have put forward some suggestions for improving the current document. If you agree, I will make corresponding changes at night, because I don't have a suitable environment to deal with it during the day

I've addressed the your suggestions.

@gtk96
Copy link
Contributor Author

gtk96 commented Aug 1, 2022

The exciting work is finished. Thank you for your guidance @leonardBang

@leonardBang
Copy link
Contributor

The exciting work is finished. Thank you for your guidance @leonardBang

Thanks @RookieGao for the great work, this is the first Chinese connector document, I'm pretty sure your contribution will help Chinese speaking user a lot.

@leonardBang
Copy link
Contributor

@RookieGao Would you also like to backport the PR to release-2.2 branch? as we recommended user to look up the latest release version instead of the master version.

@gtk96
Copy link
Contributor Author

gtk96 commented Aug 1, 2022

@RookieGao Would you also like to backport the PR to release-2.2 branch? as we recommended user to look up the latest release version instead of the master version.

of course

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonardBang leonardBang leonardBang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gtk96 @leonardBang