FINERACT-1971: external_id column of accrual activity transaction gets updated to null when an accrual activity is reversed #4246
+149
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kulminsky
force-pushed
the
FINERACT-1971/external_id_column_of_accrual_activity_transaction_gets_updated_to_null_when_an_accrual_activity_is_reversed
branch
from
881523a to
82f6d2f
Compare
adamsaghy
reviewed
Jan 8, 2025
| @@ -458,6 +458,16 @@ public void reverse(final ExternalId reversalExternalId) { | |||
| this.reversalExternalId = reversalExternalId; | |||
| } | |||
|
|
|||
| public void reverseWithExternalIdHandling(final boolean isReverseReplayed) { | |||
There was a problem hiding this comment.
This is not needed! I dont wanna move "reverse-replay" logic into the LoanTransaction entity...
adamsaghy
reviewed
Jan 8, 2025
| @@ -809,7 +808,11 @@ protected void createNewTransaction(final LoanTransaction oldTransaction, final | |||
| relations.add(LoanTransactionRelation.linkToTransaction(originalTransaction, newTransaction, CHARGEBACK)); | |||
| } | |||
| loanChargeValidator.validateRepaymentTypeTransactionNotBeforeAChargeRefund(oldTransaction.getLoan(), oldTransaction, "reversed"); | |||
| oldTransaction.reverse(); | |||
|
|
|||
There was a problem hiding this comment.
THis is not needed. The issue was not with this logic!
Here there will always be "REPLAYED" relation, so checking it again is unnecessary!
kulminsky
force-pushed
the
FINERACT-1971/external_id_column_of_accrual_activity_transaction_gets_updated_to_null_when_an_accrual_activity_is_reversed
branch
from
82f6d2f to
0c0ee04
Compare
adamsaghy
reviewed
Jan 14, 2025
| @@ -204,7 +204,14 @@ private boolean validateActivityTransaction(@NotNull LoanRepaymentScheduleInstal | |||
|
|
|||
| private void reverseAccrualActivityTransaction(LoanTransaction loanTransaction) { | |||
| loanTransaction.reverse(); | |||
| loanTransaction.updateExternalId(null); | |||
|
|
|||
There was a problem hiding this comment.
WE don't need this validation. Simply removing the part where we set the external id to null is sufficient!
…s updated to null when an accrual activity is reversed
kulminsky
force-pushed
the
FINERACT-1971/external_id_column_of_accrual_activity_transaction_gets_updated_to_null_when_an_accrual_activity_is_reversed
branch
from
0c0ee04 to
13c79bf
Compare
adamsaghy
reviewed
Jan 15, 2025
| GetLoansLoanIdResponse loanDetailsNotOverpaid = loanTransactionHelper.getLoanDetails((long) loanId); | ||
| assertFalse(loanDetailsNotOverpaid.getStatus().getOverpaid()); // Overpaid status should be false | ||
| assertNull(loanDetailsNotOverpaid.getOverpaidOnDate()); // Overpaid date should be reset | ||
| assertEquals(loanDetailsNotOverpaid.getExternalId(), loanExternalId); // externalId should remain unchanged |
There was a problem hiding this comment.
Please make sure you are validating whether the reversed transaction external id is not changed! We don't need to check whether the external id of the loan got changed!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
external_id column of accrual activity transaction gets updated to null when an accrual activity is reversed
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.