FINERACT-2060: Progressive loan - final accrual calculation on closed… #4220
Conversation
fineract-e2e-tests-core/src/test/resources/fineract-test-application.properties
Outdated
Show resolved
Hide resolved
fineract-e2e-tests-core/src/test/java/org/apache/fineract/test/helper/ErrorMessageHelper.java
Outdated
Show resolved
Hide resolved
| businessEventNotifierService.notifyPostBusinessEvent(new LoanAdjustTransactionBusinessEvent(data)); | ||
| @Override | ||
| @Transactional | ||
| public void processAccrualActivityForLoanReopen(@NotNull Loan loan) { |
There was a problem hiding this comment.
As far as I can tell this method existed before but now it's impossible to verify what was changed here exactly. Can you please revert the method reordering (same thing for others if it happened)?
if reordering makes sense, feel free to open a separate PR just for that.
There was a problem hiding this comment.
Common private methods were moved to the utility section, following the call order. Since I rewrote most of the methods here, I would like to keep this order.
There was a problem hiding this comment.
I honestly disagree with it and the reason of not reverting the method movement (rewrote most of the methods) doesn't have a ground. Even if you refactored the method bodies, you can revert the method movement - making it possible to review it.
I'll approve it just to get the ball going but next time, please keep in mind to not do unnecessary changes that makes PR reviews hell.
marta-jankovics
force-pushed
the
ps/FINERACT-2060_closure_reopen
branch
from
3bdda96 to
8d69545
Compare
… loan
Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.