Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FINERACT-1981: Embeddable Progressive Loan Schedule generator #4212

Conversation

janez89
Copy link
Contributor

@janez89 janez89 commented Dec 9, 2024

This P.R. introduces an embeddable Progressive Loan Schedule generator.

Now we introduce a new fineract module: fineract-progressive-loan-embeddable-schedule-generator. This module generates a dependency-free portable Jar.
Introduced a new CI Test to ensure the built Jar is runnable and dependency-free.
This P.R. contains refactors mostly related to the Money and MonetaryMoney classes.

If someone includes a dependency that is not part of the sample application then the CI job will fail like this:
https://github.com/janez89/fineract/actions/runs/12240841911/job/34144606937

@janez89 janez89 marked this pull request as draft December 9, 2024 13:55
@janez89 janez89 force-pushed the feature/FINERACT-1981__embeddable-progressive-loan-schedule-generator branch 3 times, most recently from 8bd567a to 3616682 Compare December 9, 2024 15:53
@janez89 janez89 marked this pull request as ready for review December 9, 2024 17:02
@janez89 janez89 force-pushed the feature/FINERACT-1981__embeddable-progressive-loan-schedule-generator branch 4 times, most recently from a59b67d to 8b21a66 Compare December 9, 2024 18:42
build.gradle Outdated
@@ -109,6 +111,7 @@ plugins {
id 'se.thinkcode.cucumber-runner' version '0.0.11' apply false
id "com.github.davidmc24.gradle.plugin.avro-base" version "1.9.1" apply false
id 'org.openapi.generator' version '7.8.0' apply false
id 'com.gradleup.shadow' version '9.0.0-beta4' apply false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having beta dependency is not nice. Would you give a try with latest stable version? 8.3.5?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Downgraded to 8.3.5. Let us see

@janez89 janez89 force-pushed the feature/FINERACT-1981__embeddable-progressive-loan-schedule-generator branch from 8b21a66 to 171de70 Compare December 10, 2024 11:21
@adamsaghy adamsaghy merged commit bb8480a into apache:develop Dec 10, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants