Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading to Gradle 7.2 #1869

Merged
merged 1 commit into from
Sep 13, 2021
Merged

Upgrading to Gradle 7.2 #1869

merged 1 commit into from
Sep 13, 2021

Conversation

ptuomola
Copy link
Contributor

@ptuomola ptuomola commented Sep 11, 2021

Description

Describe the changes made and why they were made.

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests

  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

  • Create/update unit or integration tests for verifying the changes made.

  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes

  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@ptuomola ptuomola force-pushed the gradle7 branch 2 times, most recently from e2d13e1 to fe78a83 Compare September 11, 2021 15:07
@ptuomola ptuomola marked this pull request as draft September 12, 2021 07:06
@ptuomola ptuomola marked this pull request as ready for review September 12, 2021 11:07
@ptuomola
Copy link
Contributor Author

Finally got around to fixing the compatibility issues with Gradle 7.x... pretty straightforward changes, could @xurror @vidakovic @vorburger @awasum someone review and merge please?

Copy link
Contributor

@vidakovic vidakovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vidakovic vidakovic merged commit b74501b into apache:develop Sep 13, 2021
@ptuomola ptuomola deleted the gradle7 branch September 25, 2021 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants