FINERACT-1105 Swagger generates valid Spec File #1272
Conversation
FINERACT-1105 Added description to response 200 FINERACT-1105 Valid Spec File generated FINERACT-1105 Valid Open API Spec File generated FINERACT-1105 Added description to response 200 FINERACT-1105 Valid Spec File generated
There was a problem hiding this comment.
Backporting this to 1.4.0 is fine with me, but I'd prefer the Release Manager (RM) @vidakovic to LGTM and merge this, it should be his discretion.
|
@vorburger fine with me... I'll pick this up for 1.4.0
…On Tue, Aug 25, 2020 at 5:32 PM Michael Vorburger ⛑️ < ***@***.***> wrote:
***@***.**** approved this pull request.
Backporting this to 1.4.0 is fine with me, but I'd prefer the Release
Manager (RM) @vidakovic <https://github.com/vidakovic> to LGTM and merge
this, it should be his discretion.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1272 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAC4ZLZWVKIKDFNO2LJBWTTSCPKQ7ANCNFSM4QJMETOQ>
.
|
|
@vorburger Could you let me know which steps you executed to merge this PR into 1.4.0? |
Nothing special, but note how at the very top of this PR, or likewise e.g. on #1278 it says (said) wants to merge 1 commit into apache:1.4.0 ? Basically on GitHub when you (anyone) raises a PR, there's a drop-down at the top to choose what branch you are proposing a change for. So for this PR @Grandolf49 (not me) suggested a change for To merge it, after you gave your OK in the previous comment, I then just clicked the Rebase and Merge button! 😃 |
Description
This is a backport PR of #1270 for adding the changes in Fineract
1.4.0versionChecklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.
API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm has been updated with details of any API changes.
Integration tests have been created/updated for verifying the changes made.
All Integrations tests are passing with the new commits.
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the list.)
Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide