[FELIX-5978] Ensure getClassLoader() is called in a safe way when sec… #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urity is enabled Previously URLHandlers would explode when security was on because it didn't have permission to get the ClassLoader all the way down the stack Signed-off-by: Tim Ward <[email protected]>
Calls to getClassLoader for types within the Felix implementation are safe, calls to types that can come from other bundles are not. Proxying is also only safe within a classloader. Using SecureAction to do these things will make them safe in all cases. Signed-off-by: Tim Ward <[email protected]>
…ning classes Patch from Karl Pauls (karlpauls), also tested with the other changes for FELIX-5978 Signed-off-by: Tim Ward <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Nov 6, 2019
…rity is enabled - patched provided by Tim Ward - thanks! (This closes #160) git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1846198 13f79535-47bb-0310-9956-ffa450edef68
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…urity is enabled
Previously URLHandlers would explode when security was on because it didn't have permission to get the ClassLoader all the way down the stack
Signed-off-by: Tim Ward [email protected]