Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLING-7752 - Deserializing and serializing a feature model file suffles the configurations #144

Open
wants to merge 10,000 commits into
base: trunk
Choose a base branch
from

Conversation

andreituicu
Copy link

No description provided.

cziegeler and others added 30 commits January 26, 2018 07:30
…ase class and add more tests

git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1822320 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1822740 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1822741 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1823741 13f79535-47bb-0310-9956-ffa450edef68
…l (avoiding NPE on shutdown)

git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1824285 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1824521 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1825059 13f79535-47bb-0310-9956-ffa450edef68
…ces, and set the version to 1.2.0-SNAPSHOT.

git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1825128 13f79535-47bb-0310-9956-ffa450edef68
…ackageinfos, version set to 6.0.0-SNAPSHOT, and adaption to the new R7 resolver api changes.

git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1825132 13f79535-47bb-0310-9956-ffa450edef68
…e dependency on org.osgi.core.

git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1825178 13f79535-47bb-0310-9956-ffa450edef68
…ve old, unsupported jdk profiles.

git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1825179 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1825459 13f79535-47bb-0310-9956-ffa450edef68
Signed-off-by: Raymond Augé <rotty3000@apache.org>

git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1826276 13f79535-47bb-0310-9956-ffa450edef68
cziegeler and others added 26 commits June 13, 2018 06:11
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1833439 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1833523 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1833543 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1833548 13f79535-47bb-0310-9956-ffa450edef68
… to prevent access outside the bundle cache.

git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1833597 13f79535-47bb-0310-9956-ffa450edef68
@andreituicu
Copy link
Author

Related to apache/sling-org-apache-sling-feature#2 .

@@ -201,7 +194,7 @@ public static ConfigurationFile readJSON(
int ranking = 0;
ConfigPolicy policy = ConfigPolicy.DEFAULT;

final Dictionary<String, Object> properties = new Hashtable<>();
final Dictionary<String, Object> properties = new OrderedDictionary<>();
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bosschaert @rombert I think that in this case we might have to maintain full backwards compatibility.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, here we need to keep everything backward compatible. The configurator 1.0.0 has already been released.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking a little more about this, I think we should try to implement SLING-7752 without needing any changes in the Felix Configurator. The configurator is an implementation of the OSGi Configurator Spec ( https://osgi.org/specification/osgi.cmpn/7.0.0/service.configurator.html ) which doesn't say anything about ordering. While AFAIK the Felix Configurator is currently the only implementation of this spec, in theory another implementation could be made that doesn't have such ordering and this could break SLING-7752 again if it was used with the Sling Feature model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants