[converter] Avoid losing generics information in nested types

[timothyjward]

The converter doesn't correctly handle conversion of nested generics as type information gets lost from the field/method the object is being converted into.

Signed-off-by: Tim Ward [email protected]

[rotty3000]

@timothyjward I would merge this but apparently it breaks part of the build:

Apache Felix Schematizer Service ................... FAILURE [ 1.295 s]

I'm running mvn clean verify in the converter directory.

[timothyjward]

That does appear to be caused by yet further missing type reification in the pipeline.

[rotty3000]

note that without your change the build verifies fine.

[rotty3000]

maybe the schematizer was making assumptions about the missing generic type info.

[timothyjward]

maybe the schematizer was making assumptions about the missing generic type info.

All the tests put nested data in the “right form” e.g. a String where a String is expected so the naive conversion to Object is right. My change uses the correct generic type now, fixing some previously broken situations, but still breaks when the type is a variable. This was broken before, but more obviously broken now.

[timothyjward]

The second commit goes a lot further and attempts to completely reify generics information for nested conversions. I have included further tests for nested variable usage and generic arrays. I think this is ready to merge now.

[bosschaert]

@timothyjward Thanks! I can take a look into merging this.

[bosschaert]

Note that I missed some test classes in the mentioned commit. They were added in a subsequent commit ea17d18