Idea to add CI pipeline with github actions #320
Conversation
Try with Java21
Ignore test for PoC
Revert to 17
Try with Corretto 21
|
@enapps-enorman do you have an idea why the integration test doesn't work in GitHub actions? It cannot find the variables set in the pom.xml for the bundle filename. |
@paulrutter Sorry, I don't know why that would fail. Have you tried configuring it to run maven with the --debug argument to output more details? Honestly, I don't personally use github actions for testing pull requests. I use a jenkins organization folder to manage that stuff automatically in a similar way to what the apache sling project does at: https://ci-builds.apache.org/job/Sling/job/modules/ |
|
Ok, thank you. Before diving into this further, i will await a response from the maintainers if this is something that they would like to have going forward. |
|
I would like to have PR validation with github actions. Also see #301 |
|
@paulrutter what do you think instead of using an aggregator pom (that seems otherwise unused) just using different Jobs, then these can run independently / in parallel. |
|
Also great if we can add the OSGi tck to this test. |
|
I already added the TCKs to Equinox so it should be possible, it just seems at the moment actions are not enabled for this repository at all. I'll try to provide one PR with a minimal setup and then maybe that can be merged first to base additional thing on top of it. |
|
I reverted the unneeded changes in my pr and disabled running the integration tests for the http module, somehow those don't run correctly in GitHub actions. Needs more work still. The build now succeeds with these changes. |
|
As Github Actions seem not activate here, you need to test them in "your" fork, go to the settings, enable Actions and then create a PR against your own fork to test them. |
|
Yes, i already did that. See https://github.com/blueconic/felix-dev/actions/runs/9107381646. |
|
Okay then i misread "somehow those don't run correctly in GitHub actions" sorry for that, I think we should get in the minimal working thing and then build on top of that. |
|
I meant that i couldn't get the integration tests to run in Github Actions. Hence the |
| @@ -42,7 +42,7 @@ | |||
| <module>base</module> | |||
| <module>bridge</module> | |||
| <module>inventoryprinter</module> | |||
| <module>itest</module> | |||
| <!--<module>itest</module>--> | |||
There was a problem hiding this comment.
Is this still required now -DskipITs is used?
There was a problem hiding this comment.
Yes, the regular unit tests also don't run with what's in master right now.
|
GitHub actions are active here. You can use them. Had a discussion with the Apache Infrastruktur team. But will only be executed after pr is merged. Please read also the Policy |
This unfinished PR shows the idea of using github actions on every PR to the master branch.
It would build all projects in the root pom.xml and executes the unit tests.
Only the http project has been added, itests excluded as these didn’t succeed. That needs more work.
I think this integration could help determine if a PR breaks any existing functionality, has compilation errors or uses outdated snapshot versions.
Example here: blueconic#2