Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #958] Update licenses files, add licenses of go sdk. #959

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

xwm1992
Copy link
Contributor

@xwm1992 xwm1992 commented Jun 23, 2022

Fixes ISSUE #958 .

Motivation

Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.

Modifications

Describe the modifications you've done.

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #959 (39d6d13) into master (0e5c29f) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master    #959   +/-   ##
========================================
  Coverage      8.53%   8.53%           
  Complexity      529     529           
========================================
  Files           353     356    +3     
  Lines         22747   22766   +19     
  Branches       2497    2496    -1     
========================================
+ Hits           1941    1943    +2     
- Misses        20656   20673   +17     
  Partials        150     150           
Impacted Files Coverage Δ
...che/eventmesh/trace/zipkin/ZipkinTraceService.java 64.70% <0.00%> (-29.24%) ⬇️
...he/eventmesh/runtime/boot/EventMeshHTTPServer.java 0.00% <0.00%> (ø)
...pache/eventmesh/trace/api/common/ProtocolType.java 0.00% <0.00%> (ø)
.../eventmesh/trace/api/exception/TraceException.java 0.00% <0.00%> (ø)
...mesh/trace/api/common/EventMeshTraceConstants.java 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e5c29f...39d6d13. Read the comment docs.

@ruanwenjun
Copy link
Member

@xwm1992 It seems you have deleted the license directory and submit nothing?

@ruanwenjun
Copy link
Member

ruanwenjun commented Jun 23, 2022

Need to add announce in NOTICE and LICENSE file.

@ruanwenjun ruanwenjun changed the title [ISSUE #958] Update licenses files [ISSUE #958] Update licenses files, add licenses of go sdk. Jun 23, 2022
@xwm1992
Copy link
Contributor Author

xwm1992 commented Jun 23, 2022

Need to add announce in NOTICE and LICENSE file.

Done.

Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun merged commit 22024c4 into apache:master Jun 23, 2022
@ruanwenjun ruanwenjun added this to the 1.5.0 milestone Jun 25, 2022
liuzwei pushed a commit to liuzwei/incubator-eventmesh that referenced this pull request Jul 10, 2022
xwm1992 added a commit that referenced this pull request Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants