Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format the code in eventmesh-sdk-java and eventmesh-common #874

Merged
merged 1 commit into from
May 24, 2022

Conversation

mroccyen
Copy link
Contributor

optimize some code format.

Motivation

Some of the code in the project is not well-formed

Modifications

update eventmesh-sdk-java and eventmesh-common module part code format.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the Apache EventMesh (incubating) community!!
This is your first PR in our project. We're very excited to have you onboard contributing. Your contributions are greatly appreciated!

Please make sure that the changes are covered by tests.
We will be here shortly.
Let us know if you need any help!

Want to get closer to the community?

WeChat Group:
wechat_qr

Mailing Lists:

Name Description Subscribe Unsubscribe Archive
Users User support and questions mailing list Subscribe Unsubscribe Mail Archives
Development Development related discussions Subscribe Unsubscribe Mail Archives
Commits All commits to repositories Subscribe Unsubscribe Mail Archives

@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #874 (cb1bbed) into master (6bd41a5) will increase coverage by 0.00%.
The diff coverage is 53.33%.

@@           Coverage Diff            @@
##             master    #874   +/-   ##
========================================
  Coverage      6.86%   6.86%           
  Complexity      433     433           
========================================
  Files           342     342           
  Lines         21580   21578    -2     
  Branches       2404    2404           
========================================
  Hits           1481    1481           
+ Misses        19986   19984    -2     
  Partials        113     113           
Impacted Files Coverage Δ
...org/apache/eventmesh/common/ThreadPoolFactory.java 10.52% <0.00%> (ø)
...mmon/protocol/grpc/common/BatchMessageWrapper.java 0.00% <ø> (ø)
...mon/protocol/grpc/common/SimpleMessageWrapper.java 0.00% <ø> (ø)
...esh/common/protocol/http/body/BaseRequestBody.java 0.00% <0.00%> (ø)
...entmesh/client/grpc/consumer/SubStreamHandler.java 0.00% <0.00%> (ø)
...sh/client/grpc/producer/EventMeshGrpcProducer.java 0.00% <ø> (ø)
...ventmesh/client/grpc/util/EventMeshClientUtil.java 0.00% <0.00%> (ø)
...ache/eventmesh/client/http/AbstractHttpClient.java 0.00% <ø> (ø)
...he/eventmesh/client/tcp/common/RequestContext.java 0.00% <0.00%> (ø)
.../eventmesh/common/config/ConfigurationWrapper.java 43.75% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bd41a5...cb1bbed. Read the comment docs.

@xiaoyang-sde xiaoyang-sde changed the title optimize some code format Format the code in eventmesh-sdk-java and eventmesh-common May 24, 2022
@xiaoyang-sde xiaoyang-sde added the enhancement New feature or request label May 24, 2022
@xiaoyang-sde xiaoyang-sde merged commit 96aa29d into apache:master May 24, 2022
@ruanwenjun ruanwenjun added this to the 1.5.0 milestone Jun 25, 2022
liuzwei pushed a commit to liuzwei/incubator-eventmesh that referenced this pull request Jul 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants