[ISSUE #4415] Add Promethus source connector #4492
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandaapo
reviewed
Oct 17, 2023
|
|
||
| @Override | ||
| public void commit(ConnectRecord record) { | ||
| curStartTime += interval; |
There was a problem hiding this comment.
Do you need to add logic to update the offset in this method? Otherwise, it seems that the offset data read by offsetStorageReader has always been old.
There was a problem hiding this comment.
yes, I should save end_time in offsetStorage for each time. thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4415 .
Motivation
Add Promethus source connector
Modifications
Add new source connector module for prometheus
Documentation