[ISSUE #442] Fix findings filtered by Checkstyle workflow

[SteveYurongSu]

Fixes ISSUE #442.

Motivation

Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.

I introduced CheckStyle workflow in PR #438, but did not fix the issues that Checkstyle found.

Modifications

Describe the modifications you've done.

• Fixed all findings filtered by the Checkstyle workflow.

• Modified Checkstyle config file:

<module name="RegexpSingleline">
    <property name="format" value="System\..+\.println"/>
    <property name="message" value="Prohibit invoking System.*.println in source code !"/>
</module>

[codecov-commenter]

Codecov Report

Merging #443 (9e42c41) into develop (ed446ba) will not change coverage.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##             develop    #443   +/-   ##
=========================================
  Coverage       9.80%   9.80%           
  Complexity       282     282           
=========================================
  Files            228     228           
  Lines          10785   10785           
  Branches         919     919           
=========================================
  Hits            1057    1057           
  Misses          9633    9633           
  Partials          95      95           

Impacted Files	Coverage Δ
...esh/common/protocol/http/common/ClientRetCode.java	0.00% <0.00%> (ø)
...ntmesh/common/protocol/http/common/ClientType.java	0.00% <0.00%> (ø)
...tmesh/common/protocol/http/common/RequestCode.java	0.00% <0.00%> (ø)
...ime/core/consumergroup/ConsumerGroupTopicConf.java	0.00% <0.00%> (ø)
...ocol/http/processor/BatchSendMessageProcessor.java	0.00% <ø> (ø)
...time/core/protocol/tcp/client/session/Session.java	0.00% <ø> (ø)
...client/session/push/retry/EventMeshTcpRetryer.java	0.00% <ø> (ø)
...rotocol/tcp/client/session/send/SessionSender.java	0.00% <ø> (ø)
...eventmesh/runtime/metrics/http/SummaryMetrics.java	0.00% <ø> (ø)
...g/apache/eventmesh/client/http/RemotingServer.java	0.00% <ø> (ø)
... and 3 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed446ba...9e42c41. Read the comment docs.

[ruanwenjun]

I also do the same thing at #433, if this pr is merged first, I will rebase.

[qqeasonchen]

It seems this pr needs be merged first or every other new pr will be checked failed.

[ruanwenjun]

@qqeasonchen Yes, If there are no other problems, this pr can be merged first, otherwise the other commits will be blocked.

[qqeasonchen]

Have any other guys reviewed already?

[ruanwenjun]

LGTM, When I submitted a pr, I found that the file sChat2.jks seems to break the rules in checkStyle, do we need to exclude this file? I am not sure whether this will happen.

[SteveYurongSu]

LGTM, When I submitted a pr, I found that the file sChat2.jks seems to break the rules in checkStyle, do we need to exclude this file? I am not sure whether this will happen.

@ruanwenjun Thanks for reviewing!

I have the same question. It seems that sChat2.jks is an unexpected binary file, should we remove the file? @qqeasonchen

[ruanwenjun]

LGTM, When I submitted a pr, I found that the file sChat2.jks seems to break the rules in checkStyle, do we need to exclude this file? I am not sure whether this will happen.

@ruanwenjun Thanks for reviewing!

I have the same question. It seems that sChat2.jks is an unexpected binary file, should we remove the file? @qqeasonchen

If this file is not needed, we can remove it, and if this is needed then we can filter it like below:

<module name="BeforeExecutionExclusionFileFilter">
    <property name="fileNamePattern" value="./eventmesh-runtime/conf/sChat2.jks$"/>
  </module>

Or using checkStyle-suppressions.xml

[qqeasonchen]

sChat2.jks can be removed.