[ISSUE #1490] Extract common string into Constant class #1463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1463 +/- ##
=========================================
Coverage 10.37% 10.37%
Complexity 775 775
=========================================
Files 443 443
Lines 26930 26930
Branches 2937 2937
=========================================
Hits 2795 2795
Misses 23876 23876
Partials 259 259
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jackyluo-learning
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1490.
Motivation
Modifications
extract constant into MeshMessageProtocolConstant
replace Strings with constants in MeshMessageProtocolConstant
Documentation