Optimize zookeeper block logic on app startup #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qinliujie
reviewed
Oct 30, 2017
| throw new NullPointerException("Both Runnable and Executor can not be null!"); | ||
| } | ||
| if (executor == null) { | ||
| executor = DEFAULT_EXECUTOR; |
There was a problem hiding this comment.
这个地方与之前的行为不一致，建议是传参数的时候，显示的传递 DEFAULT_EXECUTOR
qinliujie
reviewed
Oct 30, 2017
| } | ||
| started = true; | ||
| } else { | ||
| throw new IllegalStateException("Zkclient has already been started!"); |
qinliujie
reviewed
Oct 30, 2017
| client = listenableFutureTask.get(); | ||
| client.subscribeStateChanges(listener); | ||
| } catch (InterruptedException e) { | ||
| e.printStackTrace(); |
|
已修正 @qinliujie |
Closed
rolandhe
pushed a commit
to rolandhe/dubbo
that referenced
this pull request
Sep 9, 2019
Optimize zookeeper block logic on app startup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.