Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix NacosRegistry weight missing issue #5144

Merged
merged 1 commit into from
Nov 19, 2019
Merged

fix NacosRegistry weight missing issue #5144

merged 1 commit into from
Nov 19, 2019

Conversation

brucelwl
Copy link
Contributor

@brucelwl brucelwl commented Oct 8, 2019

nacos客户端默认设置weight=1.0
而dubbo权重默认设置的是100,
dubbo通过NacosRegistry注册服务时没有设置,导致权重获取bug
image

@htynkn htynkn added first-time-contributor type/bug Bugs to being fixed labels Oct 9, 2019
@brucelwl
Copy link
Contributor Author

@htynkn first-time-contributor 怎么定义?

@htynkn
Copy link
Member

htynkn commented Oct 10, 2019

@htynkn first-time-contributor 怎么定义?

This user is a first-time contributor to the dubbo repository. There is a tag in PR page

用户第一次给dubbo库贡献。右上角Github会给一个标注

屏幕快照 2019-10-10 上午9 40 41

@brucelwl
Copy link
Contributor Author

@htynkn 我应该不是第一次贡献代码了

@htynkn
Copy link
Member

htynkn commented Oct 10, 2019

这个具体Github为什么识别成首次贡献者我不太清楚,可能是账号原因,可能是commit中的邮箱配置,可能是库的问题。
这个标志只是为了统计上使用,不影响代码的review和merge。

@brucelwl
Copy link
Contributor Author

@htynkn 请几天还能在这里找到我,现在找不到了 https://github.com/apache/dubbo/graphs/contributors

@htynkn
Copy link
Member

htynkn commented Oct 10, 2019

You are right. refer to: #4955
I will send a email to github to check the logic for first-time-contributor tag

@htynkn htynkn changed the title 修复nacos默认设置weight=1.0,导致权重获取bug fix NacosRegistry weight missing issue Oct 12, 2019
@htynkn htynkn added the status/waiting-for-feedback Need reporters to triage label Oct 16, 2019
@mercyblitz mercyblitz merged commit 7797074 into apache:2.6.x Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/waiting-for-feedback Need reporters to triage type/bug Bugs to being fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants