Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RpcContext删除remoteApplicationName字段,新增consumerApplicationName字段 #4171

Closed
wants to merge 1 commit into from

Conversation

manzhizhen
Copy link

@manzhizhen manzhizhen commented May 27, 2019

fixed #3816 some problem.

What is the purpose of the change

  1. The name of RpcContext#remoteApplicationName is not very accurate, it will make people think that it is the application of the provider when the consumer calls the provider.

2.The application name of the consumer is no longer passed through REMOTE_APPLICATION_KEY, because REMOTE_APPLICATION_KEY is used in the routing label, referring to the application name of the provider, using the new field CONSUMER_APPLICATION_KEY

  1. 之前RpcContext#remoteApplicationName的名称不太准确,会让人误以为是consumer调用provider时,provider的application。所以优化成RpcContext#consumerApplicationName。

2.不再通过REMOTE_APPLICATION_KEY来传递consumer的application name,因为REMOTE_APPLICATION_KEY在路由标签中有使用,指的是provider的application name,改用新的字段CONSUMER_APPLICATION_KEY

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@manzhizhen manzhizhen closed this May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant