-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix for #4111 do not ignore empty value when we construct servicename #4112
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4112 +/- ##
============================================
+ Coverage 62.63% 62.64% +<.01%
- Complexity 543 545 +2
============================================
Files 762 762
Lines 32752 32753 +1
Branches 5162 5162
============================================
+ Hits 20515 20517 +2
+ Misses 9876 9875 -1
Partials 2361 2361
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe if no ignore empty value, two provider with same service but different config still get different service name, Is that true?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
What is the purpose of the change
XXXXX
Brief changelog
fix for #4111
do not ignore empty value when we construct servicename
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.