Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo-3875] dubbo TagRouter does not work with dubbo:parameter. #3883

Merged
merged 3 commits into from
Apr 26, 2019

Conversation

chickenlj
Copy link
Contributor

What is the purpose of the change

Fixes #3875, support using the following on consumer side:
<dubbo:parameter key="dubbo.tag" value="groupA"/>

Related issue #3359

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@chickenlj
Copy link
Contributor Author

I think we should add 'tag' as the first class supporting item in XML on consumer side.

@codecov-io
Copy link

Codecov Report

Merging #3883 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #3883      +/-   ##
===========================================
- Coverage     63.71%   63.7%   -0.01%     
  Complexity       71      71              
===========================================
  Files           712     712              
  Lines         31443   31435       -8     
  Branches       5072    5069       -3     
===========================================
- Hits          20033   20026       -7     
- Misses         9113    9115       +2     
+ Partials       2297    2294       -3
Impacted Files Coverage Δ Complexity Δ
...org/apache/dubbo/config/AbstractServiceConfig.java 100% <ø> (ø) 0 <0> (ø) ⬇️
.../dubbo/config/builders/AbstractServiceBuilder.java 97.53% <ø> (-0.12%) 0 <0> (ø)
...ubbo/config/builders/AbstractInterfaceBuilder.java 98.05% <100%> (+0.07%) 0 <0> (ø) ⬇️
.../java/org/apache/dubbo/config/ReferenceConfig.java 60.51% <100%> (-0.72%) 0 <0> (ø)
...apache/dubbo/rpc/cluster/support/ClusterUtils.java 76.27% <100%> (+5.3%) 0 <0> (ø) ⬇️
...in/java/org/apache/dubbo/config/ServiceConfig.java 56.58% <100%> (ø) 0 <0> (ø) ⬇️
...g/apache/dubbo/config/AbstractInterfaceConfig.java 72.41% <100%> (+0.23%) 0 <0> (ø) ⬇️
...ache/dubbo/remoting/p2p/support/AbstractGroup.java 45.45% <0%> (-11.37%) 0% <0%> (ø)
.../apache/dubbo/remoting/transport/AbstractPeer.java 58.69% <0%> (-4.35%) 0% <0%> (ø)
...bo/rpc/cluster/support/FailbackClusterInvoker.java 67.21% <0%> (-3.28%) 0% <0%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 201795b...407ecb6. Read the comment docs.

Copy link
Contributor

@ralf0131 ralf0131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ralf0131 ralf0131 merged commit d2be44d into apache:master Apr 26, 2019
vio-lin pushed a commit to vio-lin/incubator-dubbo that referenced this pull request Apr 29, 2019
…che#3883)

* avoid 'dubbo.tag' from provider side being override on consumer side
* not necessary to keep 'default.' prefix for configs come from ConsumerConfig and ProviderConfig
* fix ut caused by removing of 'default.' prefix
cvictory added a commit to cvictory/dubbo that referenced this pull request May 17, 2019
@chickenlj chickenlj deleted the bugfix-#3875-tagrouter branch July 2, 2020 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dubbo TagRouter does not work with dubbo:parameter
3 participants