-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make protocols a mutable list (a concrete ArrayList) #3869
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3869 +/- ##
============================================
- Coverage 63.73% 63.67% -0.06%
Complexity 71 71
============================================
Files 712 712
Lines 31443 31443
Branches 5072 5072
============================================
- Hits 20039 20022 -17
- Misses 9109 9124 +15
- Partials 2295 2297 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are Arrays.asList
and Collections.singletonList
different? Neither class supports the add () method.
dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/AbstractServiceConfig.java
Outdated
Show resolved
Hide resolved
dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ProviderConfig.java
Outdated
Show resolved
Hide resolved
dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ServiceConfig.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nitpicks on your PR.
@satansk could you help me check this? |
@moriadry one more thing, the type parameters need to be removed, otherwise LGTM |
@satansk yes, I thought we should support jdk 6 and below, I changed as you request. :) |
dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/AbstractServiceConfig.java
Outdated
Show resolved
Hide resolved
dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ProviderConfig.java
Outdated
Show resolved
Hide resolved
dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ServiceConfig.java
Outdated
Show resolved
Hide resolved
fix whitespace when git push |
dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ProviderConfig.java
Outdated
Show resolved
Hide resolved
dubbo-config/dubbo-config-api/src/test/java/org/apache/dubbo/config/url/UrlTestBase.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the pull request!
@satansk What is you opinion on this pull request? |
my pleasure! and thank you for your help:) |
* use ArrayList instead of Arrays.ArrayList
What is the purpose of the change
fix bug
issue: #3841
Brief changelog
make protocols a mutable list (a concrete ArrayList)
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.