Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polish code and fix (#3761) #3838

Merged
merged 3 commits into from
Apr 12, 2019
Merged

polish code and fix (#3761) #3838

merged 3 commits into from
Apr 12, 2019

Conversation

chenlushun
Copy link
Contributor

polish code and add javadoc

@chenlushun chenlushun changed the title polish code and add javadoc polish code and fix (#3761) Apr 10, 2019
@codecov-io
Copy link

Codecov Report

Merging #3838 into master will decrease coverage by 0.02%.
The diff coverage is 76.47%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3838      +/-   ##
============================================
- Coverage      63.6%   63.57%   -0.03%     
  Complexity       71       71              
============================================
  Files           708      708              
  Lines         31192    31191       -1     
  Branches       5048     5048              
============================================
- Hits          19839    19831       -8     
- Misses         9072     9081       +9     
+ Partials       2281     2279       -2
Impacted Files Coverage Δ Complexity Δ
.../org/apache/dubbo/cache/support/jcache/JCache.java 86.95% <ø> (ø) 0 <0> (ø) ⬇️
...data/definition/builder/CollectionTypeBuilder.java 47.61% <ø> (ø) 4 <0> (ø) ⬇️
...api/src/main/java/org/apache/dubbo/rpc/Filter.java 100% <ø> (ø) 0 <0> (ø) ⬇️
...bo/metadata/definition/model/MethodDefinition.java 39.28% <0%> (ø) 8 <0> (ø) ⬇️
...bo/metadata/definition/builder/MapTypeBuilder.java 47.61% <0%> (ø) 5 <0> (ø) ⬇️
...bo/cache/support/threadlocal/ThreadLocalCache.java 100% <100%> (ø) 0 <0> (ø) ⬇️
...he/dubbo/cache/support/expiring/ExpiringCache.java 100% <100%> (ø) 0 <0> (ø) ⬇️
...o/metadata/definition/builder/EnumTypeBuilder.java 75% <100%> (ø) 4 <0> (ø) ⬇️
...bbo/validation/support/jvalidation/JValidator.java 79.87% <100%> (ø) 0 <0> (ø) ⬇️
...ache/dubbo/cache/support/expiring/ExpiringMap.java 40.35% <100%> (ø) 0 <0> (ø) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a378a01...51e32b0. Read the comment docs.

Copy link
Contributor

@ralf0131 ralf0131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the pull request.

@ralf0131 ralf0131 merged commit 47d3cbc into apache:master Apr 12, 2019
vio-lin pushed a commit to vio-lin/incubator-dubbo that referenced this pull request Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants