Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 3785 #3824

Merged
merged 1 commit into from
Apr 9, 2019
Merged

Fix issue 3785 #3824

merged 1 commit into from
Apr 9, 2019

Conversation

carryxyh
Copy link
Member

@carryxyh carryxyh commented Apr 8, 2019

Make dynamic default true to promise that the url will delete from zk whenever provider shutdown.

Fix issue:
#3785

@carryxyh carryxyh requested a review from beiwei30 April 8, 2019 06:43
Copy link
Member

@beiwei30 beiwei30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beiwei30 beiwei30 merged commit 2bfe25e into apache:master Apr 9, 2019
@carryxyh carryxyh deleted the fix-default-dynamic branch April 11, 2019 08:01
vio-lin pushed a commit to vio-lin/incubator-dubbo that referenced this pull request Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants