Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polish code and fix some documentation errors #3818

Merged
merged 1 commit into from
Apr 7, 2019
Merged

polish code and fix some documentation errors #3818

merged 1 commit into from
Apr 7, 2019

Conversation

chenlushun
Copy link
Contributor

@chenlushun chenlushun commented Apr 7, 2019

What is the purpose of the change

polish code and fix some documentation errors

Brief changelog

org.apache.dubbo.registry.nacos.NacosRegistryFactory
org.apache.dubbo.registry.nacos.NacosRegistry

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • [] Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

Codecov Report

Merging #3818 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3818      +/-   ##
============================================
- Coverage     63.64%   63.59%   -0.06%     
  Complexity       71       71              
============================================
  Files           704      704              
  Lines         31065    31065              
  Branches       5037     5037              
============================================
- Hits          19772    19755      -17     
- Misses         9024     9038      +14     
- Partials       2269     2272       +3
Impacted Files Coverage Δ Complexity Δ
...ache/dubbo/remoting/p2p/support/AbstractGroup.java 45.45% <0%> (-11.37%) 0% <0%> (ø)
...apache/dubbo/common/config/ConfigurationUtils.java 64% <0%> (-8%) 0% <0%> (ø)
...onfig/spring/extension/SpringExtensionFactory.java 80.48% <0%> (-4.88%) 0% <0%> (ø)
...e/dubbo/remoting/transport/netty/NettyChannel.java 57.64% <0%> (-4.71%) 0% <0%> (ø)
.../exchange/support/header/HeaderExchangeServer.java 66.98% <0%> (-2.84%) 0% <0%> (ø)
.../apache/dubbo/remoting/transport/AbstractPeer.java 65.21% <0%> (-2.18%) 0% <0%> (ø)
...dubbo/remoting/exchange/support/DefaultFuture.java 75.51% <0%> (-0.69%) 0% <0%> (ø)
...pache/dubbo/remoting/transport/AbstractServer.java 47.91% <0%> (+1.04%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8445349...776e5e2. Read the comment docs.

Copy link
Contributor

@ralf0131 ralf0131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants