-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JSON-RPC protocol #3786
Add JSON-RPC protocol #3786
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3786 +/- ##
===========================================
- Coverage 63.58% 63.48% -0.1%
Complexity 71 71
===========================================
Files 704 705 +1
Lines 31063 31131 +68
Branches 5037 5048 +11
===========================================
+ Hits 19751 19765 +14
- Misses 9037 9087 +50
- Partials 2275 2279 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the LICENSE of your dependencies? Could you please list them?
The JSON-RPC moudle dependends on the <groupId>com.github.briandilley.jsonrpc4j</groupId>
<artifactId>jsonrpc4j</artifactId>
<version>1.2.0</version> and its license is <licenses>
<license>
<name>The MIT License (MIT)</name>
<url>http://opensource.org/licenses/MIT</url>
<distribution>repo</distribution>
</license>
</licenses> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the pull request.
What is the purpose of the change
add a new protocol JSON-RPC. The changes were moved from the origin repository: https://github.com/apache/incubator-dubbo-rpc-jsonrpc